3
94%
master: 97%

Ran 31 Jan 2019 11:21PM UTC

Files 83

Run time 1min

Badge

Embed ▾

Committed 31 Jan 2019 11:18PM UTC coverage: 94.337% (-0.04%) from 94.375%

Job # 2.3

Build Type

Pull #740

travis-ci

Committed by

web-flow

Commit Message

Fix query encoding for integer-indexed maps

As reported in #608, integer-indexed maps currently work when passed as
part of the body, but they are reverted to non-indexed maps when passed
in the query.

It turns out that we actually had two problems:

1. We weren't calling our `Util.encode_parameters` on our query
   parameters anywhere, and it's this method will does the integer
   encoding.

2. Even when I fixed (1) by calling `Util.encode_parameters`, Faraday
   would still strip the integer indexes as they were transformed in
   its default `NestedParamsEncoder`.

Here we fix both issues by calling `Util.encode_parameters` and sending
Faraday a custom encoder which bypasses its normal shenanigans.

Unfortunately, this has turned out to be somewhat difficult to test
because the integer-indexed maps also seem to confuse Webmock, which
strips them down to standard maps (I even tried testing against a
string, and it still got it wrong). I did use stripe-mock though to
verify that we are now sending the right payload.

Fixes #608.

Pull Request Pull Request #740: Fix query encoding for integer-indexed maps

Run Details

1666 of 1766 relevant lines covered (94.34%)

643.27 hits per line

stripe / stripe-ruby / 2907 / 3
94%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2907.3 (2.3)

stripe / stripe-ruby / 2907 / 3 94% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2907.3 (2.3)

stripe / stripe-ruby / 2907 / 3
94%
master: 97%

README BADGES
x