4
86%
9.0: 78%

Ran 28 Jan 2019 11:26AM UTC

Files 50

Run time 4s

Badge

Embed ▾

Committed 28 Jan 2019 10:46AM UTC coverage: 86.199%. Remained the same

Job # TESTS="1" ODOO_REPO="odoo/odoo"

Build Type

push

travis-ci

Committed by

pedrobaeza

Commit Message

[11.0][FIX] account_payment_mode res.partner view banks group attribute

Description of the issue/feature this PR addresses:

The modules adds `{'invisible': [('parent_id', '!=', False)]}` attribute
to `banks` group on res.partner form view. The rationale for this,
according to a comment on the view itself is:
> ... there is a domain on the 'partner_id' field of res.partner.bank
(base module) which prevents the selection of a contact

However, the domain the comment refers to is
`['|', ('is_company', '=', True), ('parent_id', '=', False)]`
So, I think the domain for the group to be invisible should be
`[('parent_id', '!=', False), ('is_company', '=', False)]`. In addition,
a parent that is a company is always its own commercial partner. So we
should have access to its payment information.

Current behavior before PR:

Bank and mandates information is hidden when a partner is a company and
has a parent.

Desired behavior after PR is merged:

Banking information should be visible if a partner is a company.

Coverage Stats

1549 of 1797 relevant lines covered (86.2%)

0.86 hits per line

OCA / bank-payment / 2022 / 4
86%
9.0: 78%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2022.4 (TESTS="1" ODOO_REPO="odoo/odoo")

OCA / bank-payment / 2022 / 4 86% 9.0: 78%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2022.4 (TESTS="1" ODOO_REPO="odoo/odoo")

OCA / bank-payment / 2022 / 4
86%
9.0: 78%

README BADGES
x