2
97%
develop: 97%

Ran 13 Feb 2015 11:32PM UTC

Files 28

Run time 23s

Badge

Embed ▾

Committed 13 Feb 2015 11:31PM UTC coverage: 93.083% (+0.002%) from 93.081%

Job # 1318.2

Build Type

Pull #462

travis-ci

Committed by

jamesls

Commit Message

Use class instance to lock signing

The `with threading.Lock()` statement does not actually lock
anything because we're creating a new lock each time.  The
fix here is to use an instance level lock.  We need to ensure that
the signer is not called in multiple threads as it is _not_ thread
safe.

This bug surfaces via S3 signature version 4 multithreaded uploads.
If you run "aws s3 cp/sync" in eu-central-1 or cn-north-1, you'll
see signature errors because the timestamp will be off be one or more
seconds.  Given this is a race condition, you'll need a fairly large
file (1GB to be safe) to see this issue.

Pull Request Pull Request #462: Use class instance to lock signing

Run Details

4387 of 4713 relevant lines covered (93.08%)

0.93 hits per line

boto / botocore / 1318 / 2
97%
develop: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1318.2

boto / botocore / 1318 / 2 97% develop: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1318.2

boto / botocore / 1318 / 2
97%
develop: 97%

README BADGES
x