1
72%
master: 72%

Ran 26 Jan 2019 02:54PM UTC

Files 494

Run time 24s

Badge

Embed ▾

Committed 26 Jan 2019 02:54PM UTC coverage: 72.316% (+0.003%) from 72.313%

Job # 341.1

Build Type

push

jenkins

Committed by Sijie Guo

Commit Message

Add semantically meaningful return values to placement policy

Currently newEnsemble and replaceBookie in EnsemblePlacementPolicy
return a apache commons Pair<> with the second argument being a
boolean to denote whether the placement conforms strictly to the
policy. From calling code, the meaning of this second value is
unclear.

This patch replaces Pair<> with an PlacementResult object, in which
the strict conformity argument is clearly labels. This will also allow
extension in the future to return more metadata about particular
placements.

Also, we shouldn't put third party library classes in interfaces.

Issue:  #1914


Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Charan Reddy Guttapalem <reddycharan18@gmail.com>, Sijie Guo <sijie@apache.org>

This closes #1916 from ivankelly/meaningful-placement-res

Run Details

26336 of 36418 relevant lines covered (72.32%)

0.72 hits per line

apache / bookkeeper / 341 / 1
72%
master: 72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 341.1

apache / bookkeeper / 341 / 1 72% master: 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 341.1

apache / bookkeeper / 341 / 1
72%
master: 72%

README BADGES
x