OCA / OCB / 4320 / 2

68%

9.0: 68%

Pull #829

travis-ci

[9.0][FIX] mail: Avoid merging thread guess methods

Before this patch, thread guessing method number 2 was polluting method number 5.

You can see that method number 2 was setting the `thread_id` variable in a place where it still didn't know if it was going to be used: https://github.com/OCA/OCB/blob/<a class=hub.com/OCA/OCB/commit/f63efa19843cd95b29e8cec82cf93a2d126d278a">f63efa198/addons/mail/models/mail_thread.py#L1013

You can also see that, in case number 2 didn't pass, method 5 also used that `thread_id` variable for its own purposes: https://github.com/OCA/OCB/blob/f63efa19843cd95b29e8cec82cf93a2d126d278a/addons/mail/models/mail_thread.py#L1093

In practice, this means that, if these conditions happen:

1. You configure `crm.lead` as a fallback model for your incoming mail server.
2. You send a message to Mr. Demo from a Sales Order with ID 100.
3. You delete the thread (delete the SO 100).
4. Mr. Demo responds via email.
5. A `crm.lead` with ID 100 exists.

Then, Mr. Demo's response would be processed as a response to `crm.lead` 100, instead of creating a new `crm.lead`.

4651 of 8545 relevant lines covered (54.43%)

0.54 hits per line