letsencrypt / boulder / 10087 / 11
66%
master: 66%

DEFAULT BRANCH: master
Ran
Files 88
Run time 6s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 63.587%. Remained the same
RUN="coverage" CONTAINER="netaccess"

cron

travis-ci

jsha 
ocsp-updater: exploit isExpired index for revoked query. (#4032)

Before modifying the `findRevokedCertificatesToUpdate` query to include `NOT
isExpired` the query shows no `possible_keys` in `EXPLAIN` output.

```
MariaDB [boulder_sa_integration]> explain SELECT serial, status, ocspLastUpdated, revokedDate, revokedReason, lastExpirationNagSent, ocspResponse, notAfter, isExpired FROM certificateStatus WHERE status = 'revoked' AND ocspLastUpdated <= revokedDate LIMIT 1000;
+------+-------------+-------------------+------+---------------+------+---------+------+------+-------------+
| id   | select_type | table             | type | possible_keys | key  | key_len | ref  | rows | Extra       |
+------+-------------+-------------------+------+---------------+------+---------+------+------+-------------+
|    1 | SIMPLE      | certificateStatus | ALL  | NULL          | NULL | NULL    | NULL |  208 | Using where |
+------+-------------+-------------------+------+---------------+------+---------+------+------+-------------+
1 row in set (0.01 sec)
```

Afterwards we see `isExpired_ocspLastUpdated_idx` is considered:

```
MariaDB [boulder_sa_integration]> explain SELECT serial, status, ocspLastUpdated, revokedDate, revokedReason, lastExpirationNagSent, ocspResponse, notAfter, isExpired FROM certificateStatus WHERE NOT isExpired AND status = 'revoked' AND ocspLastUpdated <= revokedDate LIMIT 1000;
+------+-------------+-------------------+------+-------------------------------+------+---------+------+------+-------------+
| id   | select_type | table             | type | possible_keys                 | key  | key_len | ref  | rows | Extra       |
+------+-------------+-------------------+------+-------------------------------+------+---------+------+------+-------------+
|    1 | SIMPLE      | certificateStatus | ALL  | isExpired_ocspLastUpdated_idx | NULL | NULL    | NULL |  208 | Using where |
+------+-------------+-------------------+---... (continued)

11026 of 17340 relevant lines covered (63.59%)

0.71 hits per line

Source Files on job 10087.11 (RUN="coverage" CONTAINER="netaccess")