wikimedia / parsoid / 2245 / 3

85%

master: 85%

Build Type

push

travis-ci

Committed by jenkins-bot

Commit Message

Work around aggressive exception handling in the tokenizer

We have several uses of `console.assert` in the tokenizer, but these
are dangerous: in several of the places we invoke the tokenizer, we
catch all exceptions and treat these as "match failed" and then retry
something else.  Thus the assertion failure is never seen and instead
it causes a subtle behavior shift, likely leading to difficult-to-diagnose
bugs.

Work around this by defining our own assertion method for use inside
the tokenizer which uses `env.log` to ensure the assertion failure
is seen.

Follow up to Ie26c5bfb7.

Change-Id: I45e0c05f2

Run Details

9346 of 11771 branches covered (79.4%)

14752 of 17515 relevant lines covered (84.22%)

26774.73 hits per line