wikimedia / parsoid / 2243 / 3

85%

master: 85%

Build Type

push

travis-ci

Committed by jenkins-bot

Commit Message

<a href="https://github.com/wikimedia/parsoid/commit/ba31addb7">Simplify SyncTTM and handlers

* The updated SyncTTM code eliminates the use of ranks, add, remove,
  get transforms and instead uses a prioritized list of handlers for
  every transformer.

  Every transformer now provides upto 4 handlers:
       onTag, onNewline, onEnd, onAny

  onEnd, onNewline are the most specific and invoked on EOFTk and
  NLTk respetively. If not, onTag is invoked on all other tokens.

  Lastly, onAny is invoked on all tokens unless disabled by the
  more specific handlers that were run previously. It is the fallback
  handler if the other more specific handlers leave the token unmodified.

  The abstract TokenHandler class provides default implementations
  for the above handlers which are identity transformations.

* Updated all token transformers to implement the above interface.
  In most cases, this required renaming or forwarding requests to
  existing handlers.

  To mimic the previous rank-based skip functionality, the non-onAny
  handlers can set a skip flag in the return object which causes
  the onAny handler to be skipped.

  To mimic the add/remove handler functionlity, the non-onAny handlers
  can mark the transformer inactive which causes the onAny handler
  to be skipped until it is renabled again.

* Further simplification of this interface is likely possible in later
  rounds of refactoring in the future.

* Updated genTest code and transformTests.js runner as well.
  The transformTest.js runner is much simplifed with the above changes.

* All parser tests pass.
  Initial rt testing results show no regressions.

* Performance is not affected either. In fact, timing mode runs
  of transformTests.js show ~2x speedup in the core testing code.
  But, this doesn&#39;t seem to translate into any measurable parse time
  improvements for the entire parse itself.

* TODO for later.
  - Potentially simplify code in the individ... (continued)

Run Details

9344 of 11767 branches covered (79.41%)

14748 of 17506 relevant lines covered (84.25%)

26788.52 hits per line