9
4%
master: 4%

Ran 23 Jan 2019 01:47PM UTC

Files 637

Run time 46s

Badge

Embed ▾

Committed 23 Jan 2019 01:18PM UTC coverage: 73.641%. Remained the same

Job # TEST_SUITES="testinstall" JULIA=yes CONFIGFLAGS="--disable-Werror"

Build Type

push

travis-ci

Committed by

fingolfin

Commit Message

kernel: fix wrong result bugs in partial perms code

Various computations involving T_PERM2 objects of degree 65536 returned
incorrect results. The reason was that the degree, which is always an UInt,
was stored in an UInt2. But for degree 65536, this overflows to zero, hence
the code effectively treated the permutation as the identity.

The fix is to always store the degree as UInt, not as UInt2 or UInt4 (the
latter case actually is probably fine, but let's do it right anyway).

The fix in PowPPerm2Perm2 is a bit nasty and constitutes a deoptimization; a
proper fix at this stage would involve duplicating and tweaking a bunch of
code; but I plan to rewrite this file to use C++ templates anyway, at which
point the proper fix will come almost for free. So instead of wasting time on
a "proper" fix now, let's live with this workaround for now.

Run Details

219820 of 298502 relevant lines covered (73.64%)

430799.84 hits per line

gap-system / gap / 9033 / 9
4%
master: 4%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 9033.9 (TEST_SUITES="testinstall" JULIA=yes CONFIGFLAGS="--disable-Werror")

gap-system / gap / 9033 / 9 4% master: 4%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 9033.9 (TEST_SUITES="testinstall" JULIA=yes CONFIGFLAGS="--disable-Werror")

gap-system / gap / 9033 / 9
4%
master: 4%

README BADGES
x