4
98%
master: 100%

Ran 10 Jan 2019 08:58AM UTC

Files 29

Run time 1s

Badge

Embed ▾

Committed 10 Jan 2019 08:54AM UTC coverage: 97.917% (+0.1%) from 97.782%

Job # 672.4

Build Type

Pull #157

travis-ci

Committed by

web-flow

Commit Message

config: Do not require all rule options to be set

Before, it was required to specify all the options when customizing a
rule. For instance, one could use `empty-lines: enable` or `empty-lines:
{max: 1, max-start: 2, max-end: 2}`, but not just `empty-lines: {max:
1}` (it would fail with *invalid config: missing option "max-start" for
rule "empty-lines"*).

This was a minor problem for users, but it prevented the addition of new
options to existing rules, see [1] for an example. If a new option was
added, updating yamllint for all users that customize the rule would
produce a crash (*invalid config: missing option ...*).

To avoid that, let's embed default values inside the rules themselves,
instead of keeping them in `conf/default.yaml`.

This refactor should not have any impact on existing projects. I've
manually checked that it did not change the output of tests, on
different projects:
- ansible/ansible: `test/runner/ansible-test sanity --python 3.7 --test yamllint`
- ansible/molecule: `yamllint -s test/ molecule/`
- Neo23x0/sigma: `make test-yaml`
- markstory/lint-review: `yamllint .`

[1]: https://github.com/adrienverge/yamllint/pull/151

Pull Request Pull Request #157: config: Do not require all rule options to be set

Run Details

987 of 1008 relevant lines covered (97.92%)

0.98 hits per line

adrienverge / yamllint / 672 / 4
98%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 672.4

adrienverge / yamllint / 672 / 4 98% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 672.4

adrienverge / yamllint / 672 / 4
98%
master: 100%

README BADGES
x