1
65%
master: 65%

Ran 09 Jan 2019 06:22PM UTC

Files 66

Run time 10s

Badge

Embed ▾

Committed 09 Jan 2019 05:53PM UTC coverage: 65.323%. First build

Job # 3316.1

Build Type

push

travis-ci

Committed by

hsanjuan

Commit Message

Fix #632: Add --no-stream to ipfs-cluster-ctl

tl;dr: this solves the user's immediate need and, even if not tne strictest
solution, it is the simplest one.

I think we should not have the server buffer output when we can do it rather
easily client side and have the clients use their own memory for the task even
if `stream-channels=false` would do this.

We can always change the approach, but this is the minimal solution to
json array with all the AddedOutput things.

We might not buffer at all and hack a `[`, `,` separating elements and `]`
at the end, when json encoding is enabled, etc. But that would not be clean,
specially if we mean to support more output formats at some point.

Enabling supporting stream-channels=false in the api/rest/client means adding
new methods, with tests, modifying the interface etc etc. for what is
essentially a presentation issue in "ctl" in the end. Similarly we could
buffer inside the client, but it is so trivial that I don't see advatange.
We should also start thinking about moving to streaming API endpoints and
when that moment arrives we shall revisit this discussion.

I have removed the hacky manual output parts by declaring a custom
addedOutputQuiet type which wraps added output and is understood by
the formatters.go helpers.

License: MIT
Signed-off-by: Hector Sanjuan <code@hector.link>

Coverage Stats

6642 of 10168 relevant lines covered (65.32%)

80.62 hits per line

ipfs / ipfs-cluster / 3316 / 1
65%
master: 65%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3316.1

ipfs / ipfs-cluster / 3316 / 1 65% master: 65%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3316.1

ipfs / ipfs-cluster / 3316 / 1
65%
master: 65%

README BADGES
x