TykTechnologies / tyk / 5946 / 2

Ran 08 Jan 2019 10:23PM UTC

Files 105

Run time 27s

Badge

Embed ▾

Committed 08 Jan 2019 09:35PM UTC coverage: 61.363% (+0.02%) from 61.348%

Job # LATEST_GO=true

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Fix host checker (#2049)

Current implementation has multiple flaws. 
At the moment first HostDown event happens after a number of specified tries, and if the host is still down, the next HostDown event will happen after the same number of tries. So if `time_wait` is 10s, and `failure_trigger_sample_size` 2, it means 20 seconds between events. At the same time we set redis expiration key for "host down" key, to `time_wait` + 1, which means key will be expired 9 seconds before second HostDown event. This PR fix it by setting expiration time to `time_wait` * `failure_trigger_sample_size`

Another issue is how host considered to be up. At the moment on first succesful attempt we just enabled the host, however if upstream is unstable, having single healthy attempt does not mean that it is recovered. This change makes Host UP logic work exactly like Host Down and now consider number of tries. 

Fix https://github.com/TykTechnologies/tyk/issues/2036

Run Details

9928 of 16179 relevant lines covered (61.36%)

0.68 hits per line

TykTechnologies / tyk / 5946 / 2

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5946.2 (LATEST_GO=true)

TykTechnologies / tyk / 5946 / 2

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5946.2 (LATEST_GO=true)

README BADGES
x