spacedecentral / planning-suite / 785 / 3

94%

dev: 94%

push

travis-ci

resolve #226: bounties integration (#257)

* import StandardBounties contract for tests

* pass linting

* add contracts to be imported

* set up debugger for Projects app

* addBounty integrated with StandardBounties

* integrations added and compiling

* basic projects tests passing

* lint passing

* add TODO to gauge addbounties performance limits

* fixed compile error: changed external functions back to public

* fixed linting: function order

* add spoof contracts to get other app tests running

* reorganize projects contract post-rebase

* coverage passing for range-voting again

* added boilerplate tests for fulfillBounty and acceptFulfillment

* rewrote event loggers to be more 'dry'

* added asserts for other bounty data

* added annotations, attributions, & fixed styling

 - added attribution notice for GPL-3 license
 - added contract author & title
 - added annotation headers for functions
 - added missing notice and param fields
 - renamed args _id to _repoId
 - camelcased ID to Id

* TODO: bounty activation and getfulfillment failing

 - added context & xit for 'fulfill bounty & accept fulfillment'
 - added 'cannot fulfill bounty for invalid bounty id' test under 'invalid operations'
 - removed gas price & gas limit for truffle development testrpc
 - removed FULFILL_BOUNTY_ROLE
 - TODO: debug vm exception for 'fulfill bounty & accept fulfillment'
 - TODO: add state checks for standard bounty contract, such that it reflects state changes made in projects contract

* added veriification tests for standard bounty

 - renamed 'bountiesBase' to 'registry' for consistency w/ standard bounties tests
 - added context for 'standard bounty verification tests'
 - added 'verifies that the StandardBounties registry works' test
 - added 'verifies that simple bounty contribution and activation functio
ns' test
 - added 'verifies that basic fulfillment acceptance flow works' test
 - added 'bef... (continued)

54 of 70 branches covered (77.14%)

Branch coverage included in aggregate %.

292 of 303 relevant lines covered (96.37%)

14.75 hits per line