kubeflow / pipelines / 1650 / 1

0%

master: 0%

push

travis-ci

Add the Viewer CRD controller for managing web views such as Tensorboard instances from within the Pipelines UI. (#449)

* Add initial CRD types for Viewer resource, and generate corresponding
code.

* Use controller-runtime to scaffold out a controller main

* Start adding a deployment

* Clean up and separate reconciler logic into its own package for future testing.

* Clean up with comments

* Run dep ensure

* Update auto-generate script. Only need deepcopy funcs for viewer crd types

* Cleanup previously generated but unused viewer client code

* [WIP] Adding tests

* More tests

* Completed unit tests for reconciler with logic for max viewers

* Add CRD definition, sample instance and update README.

* Fix merge conflict

* Fix readme typo for kube and add direct port-forwarding instructions.

* Add tests for when persistent volume is used with Tensorboard viewer.

Also add a sample YAML to show how to mount and use a GCE persistent
disk in the viewer CRD.

* Remove vendor directory

1249 of 1406 branches covered (88.83%)

Branch coverage included in aggregate %.

2272 of 2370 relevant lines covered (95.86%)

55.73 hits per line