• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

zulip / zulip-mobile / 3948 / 1
65%
master: 65%

Build:
DEFAULT BRANCH: master
Ran 18 Dec 2018 12:17AM UTC
Files 356
Run time 42s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

17 Dec 2018 10:04AM UTC coverage: 65.314%. Remained the same
COVERALLS_REPO_TOKEN=4eYQDtWoBJlDz2QkxoQ2UcnmJFcOB7zkv

push

travis-ci

gnprice
api: Abandon `console.warn`, just use `console.log`.

In ebda24a9b "api: Fix noisy console.error on API error responses",
we switched from passing details on a failed API request to
`console.error`, to passing them to `console.warn`.

The point of that was to avoid a red-screen error in development when
a perfectly normal API failure happens.  But now we seem to be getting
those again (perhaps after the RN v0.57 upgrade?), with this error:

    argument[0].indexOf is not a function

Apparently RN's `console.warn` is implemented in such a way that it
expects a parameter with an `indexOf` property (eg: string/array).
We pass an object for the sake of nice inspectability in the Chrome
developer console.

We don't actually make use of these messages being `warn` rather than
`log`: we've had `console.disableYellowBox = true` since 57120ba83,
upgrading to RN v0.54, back in March, so they don't produce
yellow-boxes and only show up in the debug console, much like anything
else.  And `log` works fine with an object.  So, use `console.log`.

[greg: edited commit message]

1404 of 2935 branches covered (47.84%)

Branch coverage included in aggregate %.

4859 of 6654 relevant lines covered (73.02%)

50.2 hits per line

Source Files on job 3948.1 (COVERALLS_REPO_TOKEN=4eYQDtWoBJlDz2QkxoQ2UcnmJFcOB7zkv)
  • Tree
  • List 0
  • Changed 0
  • Source Changed 0
  • Coverage Changed 0
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Build 23759
  • Travis Job 3948.1
  • 21f64aad on github
  • Prev Job for COVERALLS_REPO_TOKEN=4eYQDtWoBJlDz2QkxoQ2UcnmJFcOB7zkv on master (#7786.1)
  • Next Job for COVERALLS_REPO_TOKEN=4eYQDtWoBJlDz2QkxoQ2UcnmJFcOB7zkv on master (#7807.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc