8
67%
develop: 74%

Ran 04 Dec 2018 10:07PM UTC

Files 406

Run time 39s

Badge

Embed ▾

Committed 04 Dec 2018 09:48PM UTC coverage: 60.859% (-0.03%) from 60.889%

Job # TEST_AIIDA_BACKEND=sqlalchemy TEST_TYPE="tests"

Build Type

Pull #2287

travis-ci

Committed by

web-flow

Commit Message

Replace use of os.system with subprocess.call

- Replaces the use of os.system in aiida.common.graph with subprocess.call
The former was dangerous as it was passed arguments directly from the cmdline
via verdi graph and so would execute and valid shell string,
The solution is to use subprocess.call() which sanitises the input automatically.

- Also prints a more usful message if graphviz is possibly not installed.

Pull Request Pull Request #2287: Documented optional graphviz dependency and removed use of os.system() in draw_graph

Coverage Stats

22421 of 36841 relevant lines covered (60.86%)

0.61 hits per line

aiidateam / aiida_core / 4617 / 8
67%
develop: 74%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4617.8 (TEST_AIIDA_BACKEND=sqlalchemy TEST_TYPE="tests")

aiidateam / aiida_core / 4617 / 8 67% develop: 74%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4617.8 (TEST_AIIDA_BACKEND=sqlalchemy TEST_TYPE="tests")

aiidateam / aiida_core / 4617 / 8
67%
develop: 74%

README BADGES
x