23
37%
master: 37%

Ran 20 Nov 2018 09:01PM UTC

Files 273

Run time 15s

Badge

Embed ▾

Committed 20 Nov 2018 06:58PM UTC coverage: 74.929% (+0.08%) from 74.854%

Job # T=coverage

Build Type

push

travis-ci

Committed by

bagder

Commit Message

ares: remove fd from multi fd set when ares is about to close the fd

When using c-ares for asyn dns, the dns socket fd was silently closed
by c-ares without curl being aware. curl would then 'realize' the fd
has been removed at next call of Curl_resolver_getsock, and only then
notify the CURLMOPT_SOCKETFUNCTION to remove fd from its poll set with
CURL_POLL_REMOVE. At this point the fd is already closed.

By using ares socket state callback (ARES_OPT_SOCK_STATE_CB), this
patch allows curl to be notified that the fd is not longer needed
for neither for write nor read. At this point by calling
Curl_multi_closed we are able to notify multi with CURL_POLL_REMOVE
before the fd is actually closed by ares.

In asyn-ares.c Curl_resolver_duphandle we can't use ares_dup anymore
since it does not allow passing a different sock_state_cb_data

Closes #3238

Run Details

21776 of 29062 relevant lines covered (74.93%)

766375.61 hits per line

curl / curl / 9307 / 23
37%
master: 37%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 9307.23 (T=coverage)

curl / curl / 9307 / 23 37% master: 37%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 9307.23 (T=coverage)

curl / curl / 9307 / 23
37%
master: 37%

README BADGES
x