samvera / browse-everything / 977 / 4
100%
master: 99%

Ran 19 Nov 2018 03:34PM UTC

Files 20

Run time 1s

Badge

Committed 19 Nov 2018 03:29PM UTC coverage: 99.58%. Remained the same

Job # 2.5.1, RAILS_VERSION=5.1.6

Build Type

travis-ci

Committed by

Commit Message

remove explicit sass-rails dependency

A Rails app is generated with a sass-rails dependency, so no changes to tests were needed -- the engine-cart-generated test app adds it's own sass-rails dependency.

While current Rails releases generate with sass-rails dependency, sass-rails is sunsetted/deprecated, due to the underlying pure-ruby ruby-sass gem being deprecated, and instructs "consider switching to the sassc gem" https://github.com/sass/ruby-sass .

Rails 6.0 will perhaps depend on the sassc-rails gem instead, or perhaps the sass-rails gem itself will be changed to depend on sassc instead of sass-ruby. I am not sure if it is yet determined/done. https://github.com/rails/rails/issues/3289

But apps now may wish to switch to sassc-rails, especially if it's a new app. While sassc-rails _ought_ to be a drop-in replacement, bugs can happen, and the timeline of switching (or refraining from switching) should be up to a dependent app. However, if an app depends on both sass-rails and sassc-rails, problems can occur. https://github.com/sass/sassc-rails/issues/6

So, removing the sass-rails as an explicit dependency from browse-everything will allow dependent apps to choose sass-rails or sassc-rails themselves, switching on their own timeline, without the browse-everything dependency interfering. This change is unlikely to pose any backwards compatibility problems, as dependent apps should have sass-rails in their Gemfile already, as it is generated by Rails. In the unlikely event some dependent app did not have sass-rails independently declared as a dependency, however, they would have to add it."

Pull Request Pull Request #250: remove explicit sass-rails dependency

Run Details

711 of 714 relevant lines covered (99.58%)

39.38 hits per line

Source Files on job 977.4 (2.5.1, RAILS_VERSION=5.1.6)