8
100%
master: 99%

Ran 19 Nov 2018 03:22PM UTC

Files 19

Run time 2s

Badge

Embed ▾

Committed 19 Nov 2018 03:05PM UTC coverage: 99.577% (-0.003%) from 99.58%

Job # 2.4.4, RAILS_VERSION=5.0.7

Build Type

Pull #249

travis-ci

Committed by

web-flow

Commit Message

Remove font-awesome references

As far as we can tell, browse-everything was not using font-awesome at all. Removing the dependency and references makes the code simpler, less likely to cause dependency conflicts, and generally easier to deal with other subsequent changes.

Technical backwards incompat unlikely to effect many/any:

* If apps were counting on using font-awesome via the rails gem, but were not otherwise declaring it as a dependency,  relying on b-e to include the ruby gem or provide the '@import' in a generated file — they’ll have to do these things themselves.

* There is no longer a ‘fa3’ or ‘fa4’ class added to the BE HTML.  Unlikely to effect anyone unless they had overridden BE HHTML in weird ways; BE itself was not providing any styling making use of these classes.

Pull Request Pull Request #249: Remove font-awesome references

Run Details

706 of 709 relevant lines covered (99.58%)

38.92 hits per line

samvera / browse-everything / 974 / 8
100%
master: 99%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 974.8 (2.4.4, RAILS_VERSION=5.0.7)

samvera / browse-everything / 974 / 8 100% master: 99%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 974.8 (2.4.4, RAILS_VERSION=5.0.7)

samvera / browse-everything / 974 / 8
100%
master: 99%

README BADGES
x