2
93%
master: 95%

Ran 07 Nov 2018 09:48PM UTC

Files 3

Run time 0s

Badge

Embed ▾

Committed 07 Nov 2018 09:47PM UTC coverage: 91.957% (+0.6%) from 91.375%

Job # 75.2

Build Type

Pull #79

travis-ci

Committed by

web-flow

Commit Message

Delay connection closed (#69)

As described in the issue, get_message() was raising connection closed
even if there were pending messages. Per Nathaniel's suggestion, the
proper behavior is this:

1. If the remote endpoint closed the connection, then the local endpoint
   may continue reading all messages sent prior to closing.
2. If the local endpoint closed the connection, then the local endpoint
   may not read any more messages.

I added tests for these two conditions and implemented the behavior by
closing the ReceiveChannel inside the connection's `aclose()`. This
requires a bit of additional exception handling inside `get_message()`
and inside the reader task.

One slight surprise is that the test can't be written due to the bug
in #74! The client would hang because the reader task is blocked by
the unconsumed messages. So I changed the channel size to 32, which
allows this test to work, and I will replace this hard-coded value
when I fix #74.

Pull Request Pull Request #79: Delay connection closed (#69)

Run Details

343 of 373 relevant lines covered (91.96%)

0.92 hits per line

HyperionGray / trio-websocket / 75 / 2
93%
master: 95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 75.2

HyperionGray / trio-websocket / 75 / 2 93% master: 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 75.2

HyperionGray / trio-websocket / 75 / 2
93%
master: 95%

README BADGES
x