• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

helpscout / fancy / 202 / 1
100%
master: 100%

Build:
DEFAULT BRANCH: master
Ran 07 Nov 2018 02:34PM UTC
Files 17
Run time 32s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

07 Nov 2018 02:32PM UTC coverage: 100.0%. Remained the same
202.1

push

travis-ci

web-flow
FrameManager: Fix IE/Edge frame rendering (#33)

## FrameManager: Fix IE/Edge frame rendering

![screen recording 2018-11-06 at 05 24 pm](https://user-images.githubusercontent.com/2322354/48097846-fb534200-e1e8-11e8-9d2c-c48048f01392.gif)

(GIF: Demo'ing Frame 1 being unmounted (destroy) and remounted in Edge. No errors in console. Stays are working)

This update fixes the iFrame `SCRIPT70` error that occurs in IE/Edge
when an iFrame unmounts/remounts.

The solution was to wrap the offending code in a `try/catch`.

The code in question is designed for performance, specifically to check
for cached instances of Emotion, and serves that instance instead of
creating a brand new one.

The caching mechanism will work for all browsers excluding IE/Edge, which
unfortunately, will create new emotion instances every time as unmounted
frames cannot be properly references.

Tested on Edge, IE, and Chrome

29 of 29 branches covered (100.0%)

Branch coverage included in aggregate %.

76 of 76 relevant lines covered (100.0%)

21.49 hits per line

Source Files on job 202.1
  • Tree
  • List 0
  • Changed 1
  • Source Changed 1
  • Coverage Changed 1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Build 199
  • Travis Job 202.1
  • 2877e282 on github
  • Prev Job for on master (#200.1)
  • Next Job for on master (#203.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc