wikimedia
/
mediawiki-extensions-WikibaseDataModel
/
63
/
3
29%
master: 29%
master: 29%
|
Ran
|
Files
38
|
Run time
–
|
Badge
Embed ▾
README BADGES
|
coverage: 57.044% (+1.3%) from 55.727%
push
travis-ci
JeroenDeDauwEntityId rewrite This includes * Dropping of id prefix configurability (as previously discussed) * Separation of the id class and the entity id DataValue (EntityId no longer derives from DataValue. A new EntityIdDataValue composites in a EntrityId) * The EntityId class now has as fields entity type (string) and id serialization (string) * New ItemId and PropertyId derivatives, which in the constructor only take the id serialization. The long term goal is to make EntityId abstract * Serialization format compatibility where required. The format of the DataValue will remain the same for now Some implications * No more global state is used * No more semi-dependency from DataModel on lib * getPrefixedId is no longer evil and thus not deprecated any more * EntityId and derivatives no longer expose the id format. A FooIdDerivative that has a md5 in it can be created if that'd make sense * One can type hint against ItemId or PropertyId, which are guaranteed to be valid ids for the correct entity type This is a breaking change for Wikibase, which needs to have https://gerrit.wikimedia.org/r/#/c/80506/ merged soon after this commit goes in. Change-Id: I9b05e8305
575 of 1008 relevant lines covered (57.04%)
5.37 hits per line
