6
89%
master: 90%

Ran 19 Oct 2018 05:14AM UTC

Files 47

Run time 2s

Badge

Embed ▾

Committed 19 Oct 2018 05:02AM UTC coverage: 88.387%. Remained the same

Job # COMPILER=g++-6 CXXFLAGS="-coverage" LDFLAGS="-coverage"

Build Type

push

travis-ci

Committed by

rtobar

Commit Message

Fixed underlying type for enumeration

We previously had no explicit underlying type for our enumeration, and
therefore its range was defined by "the smallest bit field large enough
to hold all enumerators"; in this case, a 2-bit field. This therefore
didn't allow us to reliably cast some integer values that were outside
the range established by the enumerator list into the enumeration type
because the result was unspecified (and UB since C++17 actually). This
happened, for example, when trying to cast 5 into effort_t. gcc and
clang happily did it, but MSVC apparently chose to bomb out.

Having a fixed underlying type for the enumeration should allow this
type of casts work, and finally let us test reliably the bit of code
that we wanted to test.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>

Run Details

1545 of 1748 relevant lines covered (88.39%)

2326538.13 hits per line

ICRAR / libprofit / 282 / 6
89%
master: 90%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 282.6 (COMPILER=g++-6 CXXFLAGS="-coverage" LDFLAGS="-coverage")

ICRAR / libprofit / 282 / 6 89% master: 90%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 282.6 (COMPILER=g++-6 CXXFLAGS="-coverage" LDFLAGS="-coverage")

ICRAR / libprofit / 282 / 6
89%
master: 90%

README BADGES
x