5
60%
master: 66%

Ran 16 Oct 2018 10:36PM UTC

Files 437

Run time 154min

Badge

Embed ▾

Committed 16 Oct 2018 12:11PM UTC coverage: 59.569% (+0.001%) from 59.568%

Job # COVERAGE_OPTIONS="--enable-coverage" HARDENING_OPTIONS=""

Build Type

push

travis-ci

Committed by

nmathewson

Commit Message

mainloop: Set client role if ControlPort is set

It turns out that if _only_ the ControlPort is set and nothing else, tor would
simply not bootstrap and thus not start properly. Commit 67a41b63063370c2
removed that requirement for tor to be considered a "client".

Unfortunately, this made the mainloop enable basically nothing if only the
ControlPort is set in the torrc.

This commit now makes it that we also consider the ControlPort when deciding
if we are a Client or not. It does not revert 67a41b63063370c2 meaning
options_any_client_port_set() stays the same, not looking at the control port.

Fixes #27849.

Signed-off-by: David Goulet <dgoulet@torproject.org>

Run Details

41500 of 69667 relevant lines covered (59.57%)

27409.59 hits per line

torproject / tor / 2465 / 5
60%
master: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2465.5 (COVERAGE_OPTIONS="--enable-coverage" HARDENING_OPTIONS="")

torproject / tor / 2465 / 5 60% master: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2465.5 (COVERAGE_OPTIONS="--enable-coverage" HARDENING_OPTIONS="")

torproject / tor / 2465 / 5
60%
master: 66%

README BADGES
x