twitchdev / developer-rig / 1089 / 1

84%

master: 65%

push

travis-ci

fixes Live Config view height bug (#187)

* fixes ExtensionView component to use a correct string to compare with live config view

- ExtensionViewType.LiveConfig and type passed to the live config view differ, so the extension view always fell back to default 300px height instead of configured value
- adds a test for the live view height check when custom panel height is provided to stop this bug from re-occuring
- updates the panel height test to use a non standard heigh to ensure the test actually doesn't pass with the default fallback

* updates live view height test snapshot to match the new changes in passed props

* updates live config test snapshot to pass ci due to new data changes introduced by the config service props being passed down

513 of 680 branches covered (75.44%)

Branch coverage included in aggregate %.

1182 of 1343 relevant lines covered (88.01%)

6.84 hits per line