8
75%
master: 75%

Ran 08 Oct 2018 04:21PM UTC

Files 267

Run time 12s

Badge

Embed ▾

Committed 08 Oct 2018 04:14PM UTC coverage: 80.601% (-0.03%) from 80.626%

Job # BUILD_TYPE=coverage CURVE=tweetnacl DRAFT=enabled

Build Type

push

travis-ci

Committed by

bluca

Commit Message

Problem: The flag that indicates the next expected message gets set even if the send fails (#3270)

* ZMQ_DGRAM: flip more flag after successful send

In the dgram socket we have a flag that indicates the next expected message type to ensure that always a pair of "address" + "body" messages gets sent. The first one MUST have the sendmore flag, the second MUST NOT.

In case the message does not get sent because of HWM full, then the function returns EAGAIN as it should. But unfortunately the next expected message type-flag gets flipped as well. When the socket_base::send function now tries to resend the message, it became the wrong message type... If you don't stop sending pairs of messages here (like me) then the next message that gets through will be of the wrong type, which in turn crashes the udp_engine function as described in #3268

Coverage Stats

9984 of 12387 relevant lines covered (80.6%)

51952.12 hits per line

zeromq / libzmq / 4337 / 8
75%
master: 75%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4337.8 (BUILD_TYPE=coverage CURVE=tweetnacl DRAFT=enabled)

zeromq / libzmq / 4337 / 8 75% master: 75%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4337.8 (BUILD_TYPE=coverage CURVE=tweetnacl DRAFT=enabled)

zeromq / libzmq / 4337 / 8
75%
master: 75%

README BADGES
x