3
81%
master: 81%

Ran 19 Sep 2018 09:29AM UTC

Files 50

Run time 2s

Badge

Embed ▾

Committed 19 Sep 2018 09:28AM UTC coverage: 64.562% (-0.6%) from 65.175%

Job # 420.3

Build Type

push

travis-ci

Committed by

einarnn

Commit Message

SSH Host key checking (#280)

* SSH Host key checking
- before initiating connection, set preferred_key (types) to be those that we already possess for the host (if any)
- when checking known_hosts, cater for ports other than 22
- if hostkey specified, remote host /must/ match that hostkey

Formatting:
- reformat function definition for easier reading of arguments
- remove use of temporary single-character variables for clarity sake

* more tests

* remove breaking test for incorrect host key padding

* change hostkey var name to be explicit on type hostkey_b64

* revert to raising SSHError

* fix: comments & whitespace tidy

* - move known_hosts_lookup (the host entry in known_hosts, with optional port number appended)
- move into if hostkey_verify, so that setting this False won't check, even when hostkey_b64 supplied
- when checking host keys, use the existing is_known_host bool and raise Exception code (neater, fewer code paths)

* check known_hosts only if hostkey_b64 not specified

* remove unused import

* Housekeeping & Cleaning
- hostkey_b64 object creation - raise new (instead of reusing) exception with friendlier message
- import NetconfFramingError (used on line 210 in _parse11
- remove unused ncclient.xml_ import
- pep8 spacing

Coverage Stats

1401 of 2170 relevant lines covered (64.56%)

0.65 hits per line

ncclient / ncclient / 420 / 3
81%
master: 81%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 420.3

ncclient / ncclient / 420 / 3 81% master: 81%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 420.3

ncclient / ncclient / 420 / 3
81%
master: 81%

README BADGES
x