apache / bookkeeper / 211 / 1
72%
master: 72%

DEFAULT BRANCH: master
Ran
Files 439
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 72.085% (-0.2%) from 72.309%
211.1

push

jenkins

Sijie Guo 
Issue #850: Added request context across client and bookies.

Descriptions of the changes in this PR:

 - MDC context is passed to runnables, callables etc.
 - protocol extended, context is sent to bookie servers, restored there and back on client with the response.
   Hopefully did not miss some nuance on the server side, largely rely on changes in ordered executors to do all the magic.
 - did microbenchmarking of the protocol changes (strings added to protobuf, MDC context preserved/restored). Looks ok.
 - added unit tests.

(bug W-5291641) 
(bug W-5291648)


### Motivation

Troubleshooting of request-level failures/errors can be simplified if request id was passed through all the stages of the request, from threadpools on the client to bookies to the response back on the client. 
Log4j/Slf4j allows logging of MDC data so it makes sense to use this functionality for logging.

### Changes

 - MDC context is passed to runnables, callables etc.
 - protocol extended, context is sent to bookie servers, restored there and back on client with the response.
   Hopefully did not miss some nuance on the server side, largely rely on changes in ordered executors to do all the magic.
 - did microbenchmarking of the protocol changes (strings added to protobuf, MDC context preserved/restored). Looks ok.
 - added unit tests.

Master Issue: #850 




Author: Andrey Yegorov <ayegorov@salesforce.com>

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>, Venkateswararao Jujjuri (JV) <None>, Sijie Guo <sijie@apache.org>

This closes #1672 from dlg99/feature/correlation_id, closes #850

24919 of 34569 relevant lines covered (72.08%)

0.72 hits per line

Source Files on job 211.1