• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

void666 / request-promise-retry / 25 / 1
98%
master: 96%

Build:
Build:
LAST BUILD BRANCH: adjust-test-urls
DEFAULT BRANCH: master
Ran 14 Sep 2018 09:59AM UTC
Files 1
Run time 0s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

14 Sep 2018 09:57AM UTC coverage: 98.246% (-0.1%) from 98.361%
25.1

Pull #5

travis-ci

web-flow
Remove custom logger

Though nice looking, I do not think that `request-promise-retry` should
be configuring a custom logging.
Possibly, it could still keep a prefix for its logs, but IMO it should
not define specific rules.

The application using this nice library is the place to customize logging.

First time I realized this and was surprising is when I had bumped the min
log level to say warn, and was still seeing the retry related logs coming
from here.
Pull Request #5: Remove custom logger

19 of 20 branches covered (95.0%)

Branch coverage included in aggregate %.

37 of 37 relevant lines covered (100.0%)

2.57 hits per line

Source Files on job 25.1
  • Tree
  • List 0
  • Changed 1
  • Source Changed 1
  • Coverage Changed 0
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Build 13
  • Travis Job 25.1
  • c973a6da on github
  • Prev Job for on library-should-not-configure-custom-logger (#22.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc