1
79%
master: 71%

Ran 13 Sep 2018 06:36PM UTC

Files 246

Run time 23s

Badge

Embed ▾

Committed 13 Sep 2018 06:32PM UTC coverage: 67.585% (-0.003%) from 67.588%

Job # 4256.1

Build Type

push

travis-ci

Committed by

behdad

Commit Message

[dfont] Solve the mystery +2 offset thing!

Previously, ResourceForkHeader was defined as 30 bytes, having the typeCountM1 as last member.
There was a mysterious offset-by-2 in the code, derived from FontTools and JDK code this was
ported from.

In testing, I observed that typeListZ offset is actually 28.  Suggesting that the typeCountM1
does NOT actually belong to ResourceForkHeader, but belongs to the array itself.  Adjusting for
that resolves the mystery +2 offset hack, so everything is clean and good now.

This, concludes my dfont hacking.  The code looks great now, and I'm happy to leave it.
Fuzzers might disagree though, we will see!

Coverage Stats

6578 of 9733 relevant lines covered (67.58%)

2468.12 hits per line

harfbuzz / harfbuzz / 4256 / 1
79%
master: 71%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4256.1

harfbuzz / harfbuzz / 4256 / 1 79% master: 71%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4256.1

harfbuzz / harfbuzz / 4256 / 1
79%
master: 71%

README BADGES
x