4
32%
master: 32%

Ran 07 Sep 2018 02:46PM UTC

Files 53

Run time 21s

Badge

Embed ▾

Committed 07 Sep 2018 02:30PM UTC coverage: 39.851% (-0.01%) from 39.863%

Job # 1203.4

Build Type

push

travis-ci

Committed by

Geal

Commit Message

Do not forget to clear the backend token when returning ReconnectBackend

This caused an annoying bug:

- when handling ReconnectBackend, the event loop will remove from the
slab the client entry corresponding to the backend token
- the backend token could then be reused as frontend token for
another session
- then the first session is closed. In the event loop's close_client
method, we call cthe close() method on the client structure, which will
return its frontend token (still valid) and its backend token (which has
been given to another session)
- close_client will then remove all of the slab entries corresponding to
these tokens, and then removing the second session

This bug was detectable because some metrics are updated when we close a
session:
- client.connections is decremented in close_client()
- backend.connections, http.active_requests, protocol.proxy.expect,
protocol.tls.handshake, protocol.https, protocol.wss are decremented in
the session's close() method
- since the session was deleted without calling close_client, those
metrics would appear to increase indefinitely

Run Details

5352 of 13430 relevant lines covered (39.85%)

0.45 hits per line

sozu-proxy / sozu / 1203 / 4
32%
master: 32%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1203.4

sozu-proxy / sozu / 1203 / 4 32% master: 32%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1203.4

sozu-proxy / sozu / 1203 / 4
32%
master: 32%

README BADGES
x