2
91%
master: 91%

Ran 22 Aug 2018 06:08PM UTC

Files 29

Run time 5s

Badge

Embed ▾

Committed 22 Aug 2018 06:05PM UTC coverage: 92.607%. Remained the same

Job # 1126.2

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Rework the way we handle leex/yecc errors (#399)

We previously returned the low-level leex and yecc errors pretty much
verbatim, relying on our FileParseError exception module to perform any
last-minute formatting.

This change performs parse error formatting directly in Parser.parse/2,
calling :thrift_lexer.format_error/1 or :thrift_parser.format_error/1 as
appropriate. The error result is now always {:error, {line, message}}.

Also, reserved_keyword_error/2 used to raise a runtime exception. It now
returns a leex-compatible error result so that it's no longer a special
case. This was also tripping up dialyzer because the lexer pass isn't
annotated as no_return().

Run Details

739 of 798 relevant lines covered (92.61%)

356.55 hits per line

pinterest / elixir-thrift / 1126 / 2
91%
master: 91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1126.2

pinterest / elixir-thrift / 1126 / 2 91% master: 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1126.2

pinterest / elixir-thrift / 1126 / 2
91%
master: 91%

README BADGES
x