1
94%
master: 92%

Ran 21 Aug 2018 04:51AM UTC

Files 35

Run time 2s

Badge

Embed ▾

Committed 21 Aug 2018 04:48AM UTC coverage: 94.207%. Remained the same

Job # 2.1.9

Build Type

Pull #207

travis-ci

Committed by

web-flow

Commit Message

upgrade jruby to get around capybara syntax issue in jruby test runs

We routinely see an error in JRuby runs on Travis when loading the file capybara/node/actions.
The reason for this is that it contains squiggly heredocs with delimiters with quotes (<<~'JS' to be specific).
link: https://github.com/teamcapybara/capybara/blob/3.2.0/lib/capybara/node/actions.rb#L310-L331

JRuby couldn't parse squiggly heredocs with single quotes in the delimeter until 9.1.6.0.
link: https://github.com/jruby/jruby/issues/4169

Because capybara isn't a runtime dependency for spinach, making our JRuby runs on Travis use a newer version of JRuby doesn't actually affect our users.
The alternative, getting capybara's maintainers to accept a PR removing the quotes from the heredoc delimeters in that file, seems like it would take much more effort, for very little benefit.

As a side note, I have no clue what the benefit of adding quotes (single or double) to a heredoc delimeter is. Those capybara heredocs work fine with or without quotes in the delimeter.

Pull Request Pull Request #207: upgrade jruby to get around capybara syntax issue in jruby test runs

Run Details

992 of 1053 relevant lines covered (94.21%)

20.58 hits per line

codegram / spinach / 610 / 1
94%
master: 92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 610.1 (2.1.9)

codegram / spinach / 610 / 1 94% master: 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 610.1 (2.1.9)

codegram / spinach / 610 / 1
94%
master: 92%

README BADGES
x