LN-Zap / zap-desktop / 3735 / 3

12%

master: 22%

Pull #124

travis-ci

fix(lnd-detection): Lookup lnd using explicit output specifiers

`ps x -o pid,command` rather than `ps lx`

The default ps-node lookup is via ps lx, which includes:

  -l Display information associated with the following keywords:
    uid, pid, ppid, flags, cpu, pri, nice, vsz=SZ, rss, wchan,
    state=S, paddr=ADDR, tty, time, and command=CMD.

On mac, the `ps l` output can be misaligned, e.g. when some VSZ field is
longer than expected.

Many of these fields are unnecessary because we're looking up by name only,
so we can lookup using only the command fields of ps.
https://gist.github.com/ivankovacevic/9918272

More on the issue with ps-node:
https://github.com/neekey/table-parser/issues/11
https://github.com/neekey/ps/pull/64

95 of 1223 branches covered (7.77%)

Branch coverage included in aggregate %.

466 of 3334 relevant lines covered (13.98%)

0.51 hits per line