1
84%
develop: 84%

Ran 31 Jul 2018 08:35PM UTC

Files 235

Run time 31s

Badge

Embed ▾

Committed 31 Jul 2018 08:27PM UTC coverage: 83.796%. First build

Job # 3324.1

Build Type

push

travis-ci

Committed by

jwalgran

Commit Message

Monkey patch the Leaflet layer selector to work in Mobile Safari

Tapping on the layers control in Mobile Safari was not opening the layer
selector. I was not able to reproduce this issue in a separate test application,
only within OTM.

After much trial and error I discovered that changing this line
  L.DomEvent.on(el, L.Draggable.START.join(' '), stop);
to
  L.DomEvent.on(container, 'mousedown', stop); in
DomEvent.disableClickPropagation resolved the issue. Effectively, this
prevents the `touchstart` event from being stopped.

I opted to implement this as a runtime patch applied within MapManager instead
of a global patch to the Leaflet source because there are no other Leaflet
behaviors that are known to be broken in Mobile Safari and I did not want to
risk introducing a regression in some other event handling.

I minimized the chance of forgetting about this patch if/when we upgrade our
version of Leaflet by adding a comment to package.json.

Coverage Stats

18555 of 22143 relevant lines covered (83.8%)

0.84 hits per line

OpenTreeMap / otm-core / 3324 / 1
84%
develop: 84%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3324.1

OpenTreeMap / otm-core / 3324 / 1 84% develop: 84%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3324.1

OpenTreeMap / otm-core / 3324 / 1
84%
develop: 84%

README BADGES
x