puppetlabs / facter / 4390 / 6

87%

master: 87%

push

travis-ci

<a href="https://github.com/puppetlabs/facter/commit/<a class=hub.com/puppetlabs/facter/commit/125a79e4da408bb4d4a86ebb7dd71c0ca27e288f">125a79e4d<a href="https://github.com/puppetlabs/facter/commit/125a79e4da408bb4d4a86ebb7dd71c0ca27e288f">&quot;&gt;(FACT-1477) Also check for config. file when resolving selinux.enabled

Previously, we&amp;#39;d determine if selinux was enabled on a given system by
checking if the selinux filesystem is mounted. This is incorrect. Based
on https://github.com/SELinuxProject/selinux/blob/</a><a class="double-link" href="https://github.com/puppetlabs/facter/commit/<a class="double-link" href="https://github.com/puppetlabs/facter/commit/e93899c8f3c01dfb47e81d3da4b67283fb459f20">e93899c8f</a>">e93899c8f</a><a href="https://github.com/puppetlabs/facter/commit/125a79e4da408bb4d4a86ebb7dd71c0ca27e288f">/libselinux/src/enabled.c#L20, we also need to check if the selinux config. file
/etc/selinux/config also exists. We can have a scenario where the selinux
filesystem is mounted, but the /etc/selinux/config file does not exist. This
is what was happening to the customer, presumably because their kickstart file
was installing some selinux stuff under yum-utils (while our machines weren&#39;t).
Here, Facter would erroneously report that selinux is enabled.

This commit fixes our selinux enablement check by also checking for the
existence of the selinux config. file.

9799 of 11187 relevant lines covered (87.59%)

92.96 hits per line