2
91%
master: 91%

Ran 18 Jul 2018 08:21PM UTC

Files 7

Run time 1s

Badge

Embed ▾

Committed 18 Jul 2018 08:18PM UTC coverage: 94.277%. Remained the same

Job # 358.2

Build Type

push

travis-ci

Committed by

robskillington

Commit Message

Use semver dependency on Apache Thrift (#83)

Apache Thrift made a breaking api change in the 0.11 series. This package relies on the ~0.10 API. 
Currently downstream packages using dep do not inherit this package's transitive dependency constraint on apache thrift because dep does not consider revision pins when importing constraints from alternate dependency managers. By using a semver range instead of a direct pin.

Another parallel path is to propose amending Dep to consider Glide revision pins as valid transitive constraints. We can do that unilaterally in our fork of dep but it would be much better if we worked with upstream. This pull request gets us out of the immediate pain and unblocks migration to dep within Uber.

Run Details

939 of 996 relevant lines covered (94.28%)

152.26 hits per line

uber-go / tally / 358 / 2
91%
master: 91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 358.2

uber-go / tally / 358 / 2 91% master: 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 358.2

uber-go / tally / 358 / 2
91%
master: 91%

README BADGES
x