1
72%
master: 72%

Ran 17 Jul 2018 04:54PM UTC

Files 103

Run time 14s

Badge

Embed ▾

Committed 17 Jul 2018 04:54PM UTC coverage: 55.795%. Remained the same

Job # 146.1

Build Type

push

jenkins

Committed by Sijie Guo

Commit Message

ISSUE #1534: LedgerCache should be flushed

Descriptions of the changes in this PR:

### Motivation

EntryLogComparator.CompactionScannerFactory.flush just calls "ledgerStorage.updateEntriesLocations(offsets);" but not "ledgerStorage.flushEntriesLocationsIndex()".

Because of this, EntryLogCompactor.compact method would remove compacted entryLog without updated offsets/locations getting flushed/persisted/fsynced to LedgerCache (Index/FileInfo files). This could lead to data corruption/loss if Bookie is broughtdown/killed before those updated offsets/locations are flushed/persisted/fsynced.
### Changes

In EntryLogComparator, before removing compacted entryLog, LedgerCache (IndexInMemPageMgr and Index files) should be flushed, just like EntryLogger.

Master Issue: #1534

Author: cguttapalem <cguttapalem@salesforce.com>

Reviewers: Matteo Merli <mmerli@apache.org>, Sijie Guo <sijie@apache.org>

This closes #1536 from reddycharan/compactfix, closes #1534

Run Details

2017 of 3615 relevant lines covered (55.8%)

0.56 hits per line

apache / bookkeeper / 146 / 1
72%
master: 72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 146.1

apache / bookkeeper / 146 / 1 72% master: 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 146.1

apache / bookkeeper / 146 / 1
72%
master: 72%

README BADGES
x