3
99%
master: 99%

Ran 08 Jul 2018 09:52PM UTC

Files 206

Run time 11s

Badge

Embed ▾

Committed 06 Jul 2018 08:19PM UTC coverage: 98.754%. Remained the same

Job # TOXENV=cover FYI="this also tests py27"

Build Type

cron

travis-ci

Committed by

bmw

Commit Message

Do not call IPlugin.prepare() for updaters when running renew (#6167)

interfaces.GenericUpdater and new enhancement interface updater functions get run on every invocation of Certbot with "renew" verb for every lineage. This causes performance problems for users with large configurations, because of plugin plumbing and preparsing happening in prepare() method of installer plugins. This PR moves the responsibility to call prepare() to the plugin (possibly) implementing a new style enhancement interface.

Fixes: #6153

* Do not call IPlugin.prepare() for updaters when running renew

* Check prepare called in tests

* Refine pydoc and make the function name more informative

* Verify the plugin type

Coverage Stats

24890 of 25204 relevant lines covered (98.75%)

0.99 hits per line

certbot / certbot / 10349 / 3
99%
master: 99%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 10349.3 (TOXENV=cover FYI="this also tests py27")

certbot / certbot / 10349 / 3 99% master: 99%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 10349.3 (TOXENV=cover FYI="this also tests py27")

certbot / certbot / 10349 / 3
99%
master: 99%

README BADGES
x