strongloop / loopback-datasource-juggler / 4663 / 1

84%

master: 85%

push

travis-ci

Fix type definitions for PersistedModel API

Callback's first argument is an optional Error now. Was: required `any`.

PersistedModel methods return `PersistedModel` now. Before this change,
methods were returning `PersistedData` (`PersistedModel | AnyObject`).
The problem with `AnyObject` is that it does not contain any
`PersistedModel` instance data and cannot be assigned to functions
expecting `Partial<PersistedModel>`. As a result, consumers of this API
were forced to either cast the result to `PersistedModel` (which feels
wrong) or deal with the `AnyObject` case (which never happen at
runtime).

Fix definition of `ModelData<T>` to `T | Partial<T>`. Before this
change, `ModelData` allowed any values not related to the actual
model at all, for example arrays.

4304 of 5436 branches covered (79.18%)

Branch coverage included in aggregate %.

6839 of 7879 relevant lines covered (86.8%)

872.17 hits per line