7
95%
master: 95%

Ran 18 Jun 2018 10:10PM UTC

Files 44

Run time 5s

Badge

Embed ▾

Committed 18 Jun 2018 09:46PM UTC coverage: 95.492%. Remained the same

Job # SHADERC_CODE_COVERAGE=ON

Build Type

push

travis-ci

Committed by

dneto0

Commit Message

Add virtual dtor to classes with virtual functions

IncluderInterface has virtual functions but does not have a virtual
destructor. This class is derived from by FileIncluder w hich overrides
those functions.

Because there is an interface in use here, it is safe to assume some
container is storing IncluderInterface*. If the container instead held
FileIncluder* then the virtual functions wouldn't be needed.

This causes a problem since FileIncluder has member variables. The
destructor of FileIncluder knows to also destruct those member variables
(including deallocating their dynamically allocated memory).

But when IncluderInterface's destructor is called, it is not virtual and
will not call FileIncluder's destructor. So these member variables are
never destroyed and their dynamically allocated memory will be leaked.

In this case, FileIncluder stores a std::unordered_set<std::string>
which will be leaked.

This patch adds a virtual destructor to IncluderInterface to make sure
FileIncluder's destructor is called and this memory isn't leaked.

Use =default and don't redeclare IncluderInterface's dtor

Run Details

1970 of 2063 relevant lines covered (95.49%)

2172.96 hits per line

google / shaderc / 1222 / 7
95%
master: 95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1222.7 (SHADERC_CODE_COVERAGE=ON)

google / shaderc / 1222 / 7 95% master: 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1222.7 (SHADERC_CODE_COVERAGE=ON)

google / shaderc / 1222 / 7
95%
master: 95%

README BADGES
x