3
100%
master: 88%

Ran 01 Jun 2018 03:15PM UTC

Files 353

Run time 1min

Badge

Embed ▾

Committed 01 Jun 2018 02:57PM UTC coverage: 81.198% (-0.01%) from 81.211%

Job # TARGET=coverage

Build Type

push

travis-ci

Committed by

kyukhin

Commit Message

sql: remove Table lookup from ColumnsFromExprList

sqlite3ColumnsFromExprList doesn't assume that hash contains table to be
examined. Thus, assert(table != NULL) after table lookup fails for
temporary (or in other words ephemeral) objects, e.g. see sqlite_sq_...
tables. In fact, this lookup is needed only when iColumn member of
struct Expr is less than zero. On the other hand, Expr->iColumn < 0 only
for rowid (according to comments in source code) columns:
"Expr.iColumn The column index in X.Y.  -1 for the rowid."
As far as we don't have rowid anymore, remove table lookup and add
assert testing iColumn to be greater or equal to zero.

Closes #3440

Coverage Stats

61630 of 75901 relevant lines covered (81.2%)

1475247.32 hits per line

tarantool / tarantool / 12350 / 3
100%
master: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 12350.3 (TARGET=coverage)

tarantool / tarantool / 12350 / 3 100% master: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 12350.3 (TARGET=coverage)

tarantool / tarantool / 12350 / 3
100%
master: 88%

README BADGES
x