1
95%
master: 95%

Ran 28 May 2018 12:28PM UTC

Files 246

Run time 10s

Badge

Embed ▾

Committed 28 May 2018 12:28PM UTC coverage: 95.529% (-1.3%) from 96.865%

Job # 1085.1

Build Type

push

vsts

Committed by

Commit Message

Strengthen the concept of the Sink class.

Before, it would wrap, yet still internally expose an observer. Inheriting classes would access it directly and the pattern of disposing the Sink after calling OnCompleted/OnError on the wrapped observer would be on them and repeat throughout the code. This commit encapsulates the observer and exposes Forward*-methods, taking care of disposing at the right places. The result is a lot of saved duplicated code. Moreover, we find that almost all classes inheriting from Sink also implement an IObserver of some kind by themselves, so we establish a base class Sink<TSource, TTarget>. The concept of a Sink is now more obvious, i.e. it serves as the logic between the source-stream and the emitted target stream. At last, we introduce IdentitySink which will just relay events, again, this will save a lot of duplicated code. (#493)

Run Details

14015 of 14671 relevant lines covered (95.53%)

1.94 hits per line

dotnet / reactive / 1085 / 1
95%
master: 95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1085.1

dotnet / reactive / 1085 / 1 95% master: 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1085.1

dotnet / reactive / 1085 / 1
95%
master: 95%

README BADGES
x