uber-go / cadence-client / 872 / 1
65%
master: 65%

DEFAULT BRANCH: master
Ran
Files 29
Run time 2s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 65.544%. Remained the same
872.1

push

travis-ci

yiminc 
Clean up / optimize makefile, sandbox builds better. (#474)

- Removed a bunch of cruft from overly-generic makefile copypasta
  (many of it doesn't do anything here, and makes it harder to read).
- Corrected a number of dependency chains.  Let me know if I missed
  something!  I've tried to be thorough, but it's hard to be sure.
  in any case, now it shouldn't re-do work unless it's necessary, and
  it can even init in parallel (`make -j4`) from a fresh clone without
  any problems I've seen.
- I was unable to trick Glide into including the necessary packages / versions
  to reliably build things out of vendor... so now there's a `versioned_go_build.sh`
  script to do that.  It'll also warn you if there's a newer version of tool X
  available.
  - Dep can do this pretty easily, add the target command to `require`... though
    I'm not sure what that implies for users-of-this-lib.  Can investigate later.
  - If you change the version vars, it'll automatically build the new version and
    rerun as needed.  And they're not removed with `make clean`, which helps
    keep you from needing to be online to build tools.
- Last but not least: `go test ./...` is equivalent to (or better than)
  testing each package separately, and is often *much* faster because it
  doesn't spend time rebuilding everything.  And now that we're on Go 1.10, it can
  do coverage across all packages too!

---

Before all changes:
```
$ make clean
rm -rf cadence-client
rm -Rf ./build
rm -f dummy

$ time make
rm -rf .gen
go get './vendor/go.uber.org/thriftrw'
go get './vendor/go.uber.org/yarpc/encoding/thrift/thriftrw-plugin-yarpc'
thriftrw --plugin=yarpc --pkg-prefix=go.uber.org/cadence/.gen/go/ --out=.gen/go idl/github.com/uber/cadence/cadence.thrift
thriftrw --plugin=yarpc --pkg-prefix=go.uber.org/cadence/.gen/go/ --out=.gen/go idl/github.com/uber/cadence/shared.thrift
go run ./internal/cmd/tools/copyright/licensegen.go --verifyOnly
go build ... (continued)

5623 of 8579 relevant lines covered (65.54%)

113.74 hits per line

Source Files on job 872.1