4
92%
main: 95%

Ran 23 May 2018 03:55PM UTC

Files 55

Run time 7s

Badge

Embed ▾

Committed 23 May 2018 03:39PM UTC coverage: 89.485% (-0.003%) from 89.488%

Job # TOXENV=pypy

Build Type

push

travis-ci

Committed by

PCManticore

Commit Message

Rewrite the comprehension-escape and exception-escape to work only on the corresponding nodes

These two checks were implemented in terms of visit_namne, that is, for every name in the tree,
we looked to see if that name leaked. This was resulting in a couple of false positives
and also in a performance issue, since we were calling nodes_of_class() and scope() for each
name node. Instead, this approach uses the visit methods for exception and comprehension nodes
and looks to see from there if the current scope uses leaked names.
This is not the ideal situation as well, ideal would be to have access to the definition
frame of each name, but that requires some extra engineering effort in astroid to get it right.
Close #2106

Run Details

10000 of 11175 relevant lines covered (89.49%)

0.89 hits per line

PyCQA / pylint / 2191 / 4
92%
main: 95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2191.4 (TOXENV=pypy)

PyCQA / pylint / 2191 / 4 92% main: 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2191.4 (TOXENV=pypy)

PyCQA / pylint / 2191 / 4
92%
main: 95%

README BADGES
x