tpm2-software / tpm2-abrmd / 779 / 1

80%

master: 80%

push

travis-ci

<a href="https://github.com/tpm2-software/tpm2-abrmd/commit/<a class=hub.com/tpm2-software/tpm2-abrmd/commit/07de3ab64a3b7315bf9df49cdfb953a30391d5e6">07de3ab64<a href="https://github.com/tpm2-software/tpm2-abrmd/commit/07de3ab64a3b7315bf9df49cdfb953a30391d5e6">&quot;&gt;Revert &amp;quot;Add scan-build Static Code Analysis to Travis&quot;

This reverts commit </a><a class="double-link" href="https://github.com/tpm2-software/tpm2-abrmd/commit/<a class="double-link" href="https://github.com/tpm2-software/tpm2-abrmd/commit/f05f2a850efc88b99e87da31a2316053fe0fe45f">f05f2a850</a>">f05f2a850</a><a href="https://github.com/tpm2-software/tpm2-abrmd/commit/07de3ab64a3b7315bf9df49cdfb953a30391d5e6">. The issue
with this commit is that, while it enables scan-build, it overwrites the
contents of CFLAGS and causes the build to fail (all -I directives to
the compiler have been lost and so it can&#39;t find the TSS@ headers). Odly
enough, because scan-build didn&#39;t find any errors (the build failed so
no errors to find) it still reports success. This isn&#39;t what we want.

The right solution here will preserve CFLAGS. A simple change like this
however causes the build to pass complete, scan-build to run, but it
then finds a pile of issues and so the build fails. For the short-term
we&#39;re reverting this commit and will resubmit it once the issues
identified by scan-build are resolved.

Signed-off-by: Philip Tricca <philip.b.tricca@intel.com>

2852 of 3486 relevant lines covered (81.81%)

377.27 hits per line