3
100%
master: 88%

Ran 11 May 2018 07:15AM UTC

Files 349

Run time 14s

Badge

Embed ▾

Committed 11 May 2018 06:57AM UTC coverage: 80.734% (-0.004%) from 80.738%

Job # TARGET=coverage

Build Type

push

travis-ci

Committed by

kyukhin

Commit Message

sql: Generate rowid by counter

The function `OP_NextIdEphemeral` do not produce unique ids.
The new way to get rowid is to create sequential a counter.
One of registers initializes with int64_t = 0 and increases after each
insert. There are similar cases in `select.c` file, however, they are not as
straight-forward and would be fixed in future commits.

In case of error in `tarantoolSqlite3EphemeralGetMaxId` it was creating
diag string and silently continue working. It was a huge luck that
non-valid output of the function did not lead to crashes.

After the fix, it was found that some opcodes in `select.c` were using
wrong registers. These were fixed too, but they still have bugs. For
more information see #3297.

Also, fixed a memory leak.

Related to #3297

Coverage Stats

60751 of 75248 relevant lines covered (80.73%)

1509051.27 hits per line

tarantool / tarantool / 12046 / 3
100%
master: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 12046.3 (TARGET=coverage)

tarantool / tarantool / 12046 / 3 100% master: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 12046.3 (TARGET=coverage)

tarantool / tarantool / 12046 / 3
100%
master: 88%

README BADGES
x