5
94%
master: 97%

Ran 10 May 2018 10:02PM UTC

Files 61

Run time 6s

Badge

Embed ▾

Committed 10 May 2018 09:56PM UTC coverage: 93.703%. First build

Job # 2.4.0

Build Type

push

travis-ci

Committed by

brandur

Commit Message

Add `frozen_string_literal` to every file and enforce Rubocop rule

Adds the magic `frozen_string_literal: true` comment to every file and
enables a Rubocop rule to make sure that it's always going to be there
going forward as well.

See here for more background [1], but the basic idea is that unlike many
other languages, static strings in code are mutable by default. This has
since been acknowledged as not a particularly good idea, and the
intention is to rectify the mistake when Ruby 3 comes out, where all
string literals will be frozen. The `frozen_string_literal` magic
comment was introduced in Ruby 2.3 as a way of easing the transition,
and allows libraries and projects to freeze their literals in advance.

I don't think this is breaking in any way: it's possible that users
might've been pulling out one of are literals somehow and mutating it,
but that would probably not have been useful for anything and would
certainly not be recommended, so I'm quite comfortable pushing this
change through as a minor version.

As discussed in #641.

[1] https://stackoverflow.com/a/37799399

Run Details

1488 of 1588 relevant lines covered (93.7%)

346.19 hits per line

stripe / stripe-ruby / 2354 / 5
94%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2354.5 (2.4.0)

stripe / stripe-ruby / 2354 / 5 94% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2354.5 (2.4.0)

stripe / stripe-ruby / 2354 / 5
94%
master: 97%

README BADGES
x