7
90%
master: 90%

Ran 10 May 2018 07:01PM UTC

Files 8

Run time 0s

Badge

Embed ▾

Committed 10 May 2018 06:54PM UTC coverage: 89.602% (-0.08%) from 89.677%

Job # 244.7

Build Type

Pull #91

travis-ci

Committed by

web-flow

Commit Message

Fix list index regex and _bad_pointer return value.

Metadata.pm: fix buggy list index match regex and
make sure _bad_pointer doesn't return an empty list.

The old regex for matching valid list indices -- `/^[1-9]*[0-9]$/ -- was buggy:
it rejected any indices containing non-final 0's, so it began to give false
negatives for 100-109 and similarly higher up. While it is perhaps unlikely
that there will be any lists that long in metadata those indices *are*
valid and should be accepted. The new regex is `/^[1-9][0-9]*$|^0$/`.
While it has lone zero in a separate branch it is reasonably fast because
the first branch will fail immediately on an initial 0 and the second
branch then tried immediately, failing if anything follows the 0.

In the course of fixing the above bug I noticed that _bad_pointer
returned nothing rather than an explicit undefined value in non-strict
mode, which led to wrong results when calling `value()` in list context,
since the return values for rejected pointers would just be missing.

I added tests for both thnese things to pointer.t

Pull Request Pull Request #91: Json pointer Fix list index regex and _bad_pointer return value.

Run Details

586 of 654 relevant lines covered (89.6%)

191.46 hits per line

nichtich / Pandoc-Elements / 244 / 7
90%
master: 90%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 244.7

nichtich / Pandoc-Elements / 244 / 7 90% master: 90%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 244.7

nichtich / Pandoc-Elements / 244 / 7
90%
master: 90%

README BADGES
x