2
88%
master: 88%

Ran 03 May 2018 07:48PM UTC

Files 2

Run time 2s

Badge

Embed ▾

Committed 03 May 2018 07:47PM UTC coverage: 56.25%. Remained the same

Job # BUILD_TYPE=cmake ZMQ_VERSION=4.2.0

Build Type

Pull #219

travis-ci

Committed by

web-flow

Commit Message

Problem: poller can segfault when modified from registred handler.

It is possible that a user would like to add/remove sockets from
handlers. As handlers and poll items might be removed while not
being processed yet - we have a segfault situation.
Provided unit test `remove_from_handler` demonstrates the problem.

Solution: Modify internal poll item data structure only after processing
of events is finished.

Please not that events processing path performance remains the same when there are
no modification (add/remove) to the poller (no rebuild) - main real use case.

As an effect of changes `size()` method has been removed as it does not
represent any meaningful information anymore. There are active and pending
(waiting for rebuild) poll items so two different sizes. User can
easily track on their side number of registered sockets if original size
information is needed.

`wait` method returns number of processed sockets now. It might be
useful information to a user for no extra cost.

Pull Request Pull Request #219: Problem: poller can segfault when modified from registered handler.

Coverage Stats

36 of 64 relevant lines covered (56.25%)

3.69 hits per line

zeromq / cppzmq / 68 / 2
88%
master: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 68.2 (BUILD_TYPE=cmake ZMQ_VERSION=4.2.0)

zeromq / cppzmq / 68 / 2 88% master: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 68.2 (BUILD_TYPE=cmake ZMQ_VERSION=4.2.0)

zeromq / cppzmq / 68 / 2
88%
master: 88%

README BADGES
x